azurerm_nginx_deployment - support for the auto_scale_profile property

[puneetsarna]

Acceptance test:

terraform-provider-azurerm $ make acctests SERVICE='nginx' TESTARGS='-run=TestAccNginxDeployment_autoscaling' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/nginx -run=TestAccNginxDeployment_autoscaling -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNginxDeployment_autoscaling
=== PAUSE TestAccNginxDeployment_autoscaling
=== CONT  TestAccNginxDeployment_autoscaling
--- PASS: TestAccNginxDeployment_autoscaling (490.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/nginx	493.336s

[puneetsarna]

This PR stays as a draft which is pending #24868

[puneetsarna]

TODOs:

• user facing docs. ✅
• Update tests to account for capacity/autoscale ExactlyOneOf. ✅
• Run autoscaling tests. ✅

[stephybun]

Thanks for this PR @puneetsarna. I think there is a breaking change in the way the existing capacity property has been modified to support the new auto_scale_profile block. I also have some suggestions around property naming and the documentation. If you could take a look and address those comments left in-line then we can take another look through this.

[stephybun]

Thanks @puneetsarna, a few more minor comments around the spacing in the tests and on leaving a comment on the desired behaviour for the next major release. Once those are addressed this should be good to go!

[stephybun]

If the desired behaviour is ExactlyOneOf then we usually wrap this around the features.FourPointOh flag or at the very least leave a TODO 4.0 comment so that maintainers know a breaking change needs to be introduced here for the next major release

Suggested change

	ConflictsWith: []string{"auto_scale_profile"},
	// TODO 4.0 replace this with ExactlyOneOf
	ConflictsWith: []string{"auto_scale_profile"},

[puneetsarna]

👍 Thanks for sharing this. After an internal chat within our team, I think we'd like to leave the breaking change off entirely for now as we are also evaluating other changes as well which might impact some behavior in Terraform.

Given it's unclear from our end around what those changes might be and the associated timelines, this comment might be confusing, and I am going to leave it off for the time being.

[puneetsarna]

Hi @stephybun Thanks for the helping out with the review and for sharing the details around breaking changes. I have addressed all the feedback you shared. Please let me know if there is anything else 👍

[stephybun]

Thanks @puneetsarna LGTM 🍰

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.