Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server: make the SQL administrator optional when using AAD-only authentication #15771

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

manicminer
Copy link
Contributor

Closes: #15697

Verified

This commit was signed with the committer’s verified signature.
manicminer Tom Bamford
…AAD-only authentication

Closes: #15697
@manicminer manicminer added enhancement service/mssql Microsoft SQL Server labels Mar 9, 2022
@manicminer manicminer added this to the v2.99.0 milestone Mar 9, 2022
@manicminer manicminer requested a review from a team March 9, 2022 14:32
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2022-03-10 at 11 37 31

@manicminer manicminer merged commit f1ae084 into main Mar 10, 2022
@manicminer manicminer deleted the f/mssql-server-optional-sql-admin branch March 10, 2022 11:38
manicminer added a commit that referenced this pull request Mar 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

This functionality has been released in v2.99.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants