Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to allow 'aws-marketplace' as a valid arn string in the arn prefix #41867

Merged

Conversation

generalconsensus-omf
Copy link
Contributor

Description

This allows for build components to use the arn prefix including the string 'aws-marketplace'

I'm not at liberty to use testacc on company accounts so I ran the full test suite and output the relevant section below

Relations

Closes #41818

References

Output from Acceptance Testing

ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       17.654s
...

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@generalconsensus-omf generalconsensus-omf requested a review from a team as a code owner March 14, 2025 19:56
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ewbankkit ewbankkit self-assigned this Mar 17, 2025
@ewbankkit ewbankkit added the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 17, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@generalconsensus-omf Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7cdccc1 into hashicorp:main Mar 17, 2025
32 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.92.0 milestone Mar 17, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 20, 2025
Copy link

This functionality has been released in v5.92.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_imagebuilder_image_recipe does not accept marketplace component ARN (invalid ARN)
3 participants