Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/New resource X-Ray Resource Policy #41517

Merged
merged 13 commits into from
Feb 24, 2025
Merged

F/New resource X-Ray Resource Policy #41517

merged 13 commits into from
Feb 24, 2025

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Feb 22, 2025

Description

New Resource X-Ray Resource Policy

Relations

Closes #30764

References

Output from Acceptance Testing

> make testacc PKG=xray TESTS=TestAccXRayResourcePolicy_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/xray/... -v -count 1 -parallel 20 -run='TestAccXRayResourcePolicy_'  -timeout 360m -vet=off
2025/02/21 16:11:55 Initializing Terraform AWS Provider...
=== RUN   TestAccXRayResourcePolicy_basic
=== PAUSE TestAccXRayResourcePolicy_basic
=== RUN   TestAccXRayResourcePolicy_disappears
=== PAUSE TestAccXRayResourcePolicy_disappears
=== CONT  TestAccXRayResourcePolicy_basic
=== CONT  TestAccXRayResourcePolicy_disappears
--- PASS: TestAccXRayResourcePolicy_disappears (10.74s)
--- PASS: TestAccXRayResourcePolicy_basic (12.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       19.602s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/xray Issues and PRs that pertain to the xray service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 22, 2025
@nam054 nam054 marked this pull request as ready for review February 24, 2025 06:15
@nam054 nam054 requested a review from a team as a code owner February 24, 2025 06:15
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 24, 2025
@ewbankkit ewbankkit self-assigned this Feb 24, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccXRayResourcePolicy_' PKG=xray
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/xray/... -v -count 1 -parallel 20  -run=TestAccXRayResourcePolicy_ -timeout 360m -vet=off
2025/02/24 13:14:22 Initializing Terraform AWS Provider...
=== RUN   TestAccXRayResourcePolicy_basic
=== PAUSE TestAccXRayResourcePolicy_basic
=== RUN   TestAccXRayResourcePolicy_disappears
=== PAUSE TestAccXRayResourcePolicy_disappears
=== CONT  TestAccXRayResourcePolicy_basic
=== CONT  TestAccXRayResourcePolicy_disappears
--- PASS: TestAccXRayResourcePolicy_disappears (10.72s)
--- PASS: TestAccXRayResourcePolicy_basic (12.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	18.303s

@nam054 nam054 merged commit 5510140 into main Feb 24, 2025
57 checks passed
@nam054 nam054 deleted the f-xray_resource_policy branch February 24, 2025 18:32
@github-actions github-actions bot added this to the v5.89.0 milestone Feb 24, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 24, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 28, 2025
Copy link

This functionality has been released in v5.89.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/xray Issues and PRs that pertain to the xray service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_xray_resource_policy
2 participants