Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macie2: Remove ForceNew from tags #41266

Merged
merged 13 commits into from
Feb 21, 2025
Merged

macie2: Remove ForceNew from tags #41266

merged 13 commits into from
Feb 21, 2025
+1,388 −960

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 6, 2025 •
edited
Loading

Description

Macie2 resource tags can be updated.
Discovered while working on #41253.

Relations

Closes #38778.
Closes #20726.
Closes #40548.

Output from Acceptance Testing

% AWS_MACIE2_ALTERNATE_ACCOUNT_EMAIL=xyz@example.com make testacc TESTARGS='-run=TestAccMacie2_serial/^Member$$' PKG=macie2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/^Member$ -timeout 360m -vet=off
2025/02/06 14:38:05 Initializing Terraform AWS Provider...
=== RUN   TestAccMacie2_serial
=== PAUSE TestAccMacie2_serial
=== CONT  TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/Member
=== RUN   TestAccMacie2_serial/Member/invite_removed
=== RUN   TestAccMacie2_serial/Member/status
=== RUN   TestAccMacie2_serial/Member/basic
=== RUN   TestAccMacie2_serial/Member/disappears
=== RUN   TestAccMacie2_serial/Member/tags
=== RUN   TestAccMacie2_serial/Member/invitation_disable_email_notification
=== RUN   TestAccMacie2_serial/Member/invite
--- PASS: TestAccMacie2_serial (212.14s)
    --- PASS: TestAccMacie2_serial/Member (212.14s)
        --- PASS: TestAccMacie2_serial/Member/invite_removed (32.50s)
        --- PASS: TestAccMacie2_serial/Member/status (32.85s)
        --- PASS: TestAccMacie2_serial/Member/basic (19.10s)
        --- PASS: TestAccMacie2_serial/Member/disappears (16.53s)
        --- PASS: TestAccMacie2_serial/Member/tags (48.03s)
        --- PASS: TestAccMacie2_serial/Member/invitation_disable_email_notification (31.09s)
        --- PASS: TestAccMacie2_serial/Member/invite (32.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	217.789s
% make testacc TESTARGS='-run=TestAccMacie2_serial/^ClassificationJob$$' PKG=macie2  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/^ClassificationJob$ -timeout 360m -vet=off
2025/02/20 15:51:02 Initializing Terraform AWS Provider...
=== RUN   TestAccMacie2_serial
=== PAUSE TestAccMacie2_serial
=== CONT  TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationJob
=== RUN   TestAccMacie2_serial/ClassificationJob/complete
=== RUN   TestAccMacie2_serial/ClassificationJob/tags
=== RUN   TestAccMacie2_serial/ClassificationJob/bucket_criteria
=== RUN   TestAccMacie2_serial/ClassificationJob/basic
=== RUN   TestAccMacie2_serial/ClassificationJob/name_generated
=== RUN   TestAccMacie2_serial/ClassificationJob/name_prefix
=== RUN   TestAccMacie2_serial/ClassificationJob/disappears
=== RUN   TestAccMacie2_serial/ClassificationJob/status
--- PASS: TestAccMacie2_serial (173.65s)
    --- PASS: TestAccMacie2_serial/ClassificationJob (173.65s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/complete (30.66s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/tags (43.46s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/bucket_criteria (22.26s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/basic (17.14s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_generated (17.25s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/name_prefix (17.44s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/disappears (14.98s)
        --- PASS: TestAccMacie2_serial/ClassificationJob/status (29.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	179.251s
% make testacc TESTARGS='-run=TestAccMacie2_serial/^CustomDataIdentifier$$' PKG=macie2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/^CustomDataIdentifier$ -timeout 360m -vet=off
2025/02/21 11:51:46 Initializing Terraform AWS Provider...
=== RUN   TestAccMacie2_serial
=== PAUSE TestAccMacie2_serial
=== CONT  TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/CustomDataIdentifier
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/name_generated
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/disappears
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/name_prefix
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/classification_job
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/tags
=== RUN   TestAccMacie2_serial/CustomDataIdentifier/basic
--- PASS: TestAccMacie2_serial (98.82s)
    --- PASS: TestAccMacie2_serial/CustomDataIdentifier (98.82s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/name_generated (13.18s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/disappears (10.70s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/name_prefix (12.41s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/classification_job (16.91s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/tags (32.88s)
        --- PASS: TestAccMacie2_serial/CustomDataIdentifier/basic (12.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	104.220s
% make testacc TESTARGS='-run=TestAccMacie2_serial/^FindingsFilter$$' PKG=macie2     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/^FindingsFilter$ -timeout 360m -vet=off
2025/02/21 12:28:45 Initializing Terraform AWS Provider...
=== RUN   TestAccMacie2_serial
=== PAUSE TestAccMacie2_serial
=== CONT  TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/FindingsFilter
=== RUN   TestAccMacie2_serial/FindingsFilter/complete
=== RUN   TestAccMacie2_serial/FindingsFilter/date
=== RUN   TestAccMacie2_serial/FindingsFilter/number
=== RUN   TestAccMacie2_serial/FindingsFilter/tags
=== RUN   TestAccMacie2_serial/FindingsFilter/basic
=== RUN   TestAccMacie2_serial/FindingsFilter/name_generated
=== RUN   TestAccMacie2_serial/FindingsFilter/name_prefix
=== RUN   TestAccMacie2_serial/FindingsFilter/disappears
--- PASS: TestAccMacie2_serial (149.00s)
    --- PASS: TestAccMacie2_serial/FindingsFilter (149.00s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/complete (27.65s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/date (19.94s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/number (20.46s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/tags (31.29s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/basic (12.73s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/name_generated (12.87s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/name_prefix (12.79s)
        --- PASS: TestAccMacie2_serial/FindingsFilter/disappears (11.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	154.528s

@ewbankkit
macie2: Generate 'listTags' and 'updateTags'.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
22705aa
@ewbankkit
r/aws_macie2_member: Allow tags to be updated in-place.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6683068
@ewbankkit
r/aws_macie2_member: Tidy up.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b854e68
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/macie2 Issues and PRs that pertain to the macie2 service. tags Pertains to resource tagging. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 6, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 21, 2025
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. labels Feb 21, 2025
@ewbankkit ewbankkit marked this pull request as ready for review February 21, 2025 17:32
@ewbankkit ewbankkit requested a review from a team as a code owner February 21, 2025 17:32
jar-b
jar-b approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 683f293 into main Feb 21, 2025
68 checks passed
@ewbankkit ewbankkit deleted the f-macie2-tags branch February 21, 2025 19:30
@github-actions github-actions bot added this to the v5.89.0 milestone Feb 21, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 21, 2025
Update CHANGELOG.md for #41266
d12701e
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 28, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.89.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/macie2 Issues and PRs that pertain to the macie2 service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.89.0
2 participants
@ewbankkit @jar-b