Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove library_versions workflow #38884

Merged
merged 1 commit into from
Aug 15, 2024
Merged

ci: remove library_versions workflow #38884

merged 1 commit into from
Aug 15, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 15, 2024

Description

This workflow was intended to check for the presence of net-new usage of the AWS SDK for Go V1. We have now migrated almost 80% of services off of V1 of the SDK and this check, while well intended, often misfires due to the way in which merges are applied on pull requests before producing a diff. For these reasons this check has likely outlived it's benefit and can be removed to reduce unnecessary pull request comment noise.

This workflow was intended to check for the presence of net-new usage of the AWS SDK for Go V1. We have now migrated almost 80% of services off of V1 of the SDK and this check, while well intended, often misfires due to the way in which merges are applied on pull requests before producing a diff. For these reasons this check has likely outlived it's benefit and can be removed to reduce unnecessary pull request comment noise.
@jar-b jar-b requested review from breathingdust, justinretzolk and a team as code owners August 15, 2024 14:53
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 15, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b jar-b merged commit 76c0e71 into main Aug 15, 2024
28 of 29 checks passed
@jar-b jar-b deleted the td-remove-aws-sdk-action branch August 15, 2024 19:12
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants