-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove library_versions workflow #38884
Conversation
This workflow was intended to check for the presence of net-new usage of the AWS SDK for Go V1. We have now migrated almost 80% of services off of V1 of the SDK and this check, while well intended, often misfires due to the way in which merges are applied on pull requests before producing a diff. For these reasons this check has likely outlived it's benefit and can be removed to reduce unnecessary pull request comment noise.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This workflow was intended to check for the presence of net-new usage of the AWS SDK for Go V1. We have now migrated almost 80% of services off of V1 of the SDK and this check, while well intended, often misfires due to the way in which merges are applied on pull requests before producing a diff. For these reasons this check has likely outlived it's benefit and can be removed to reduce unnecessary pull request comment noise.