Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_bedrockagent_agent_action_group: updates function_schema to allow other tagged union types #38438

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

gdavison
Copy link
Contributor

Description

The aws_bedrockagent_agent_action_group parameter function_schema is a tagged union type, so needs an extra level of indirection to capture the types.

Output from Acceptance Testing

% make testacc PKG=bedrockagent TESTS=TestAccBedrockAgentAgentActionGroup_

--- PASS: TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl (35.69s)
--- PASS: TestAccBedrockAgentAgentActionGroup_APISchema_s3 (42.56s)
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (49.53s)
--- PASS: TestAccBedrockAgentAgentActionGroup_update (56.04s)
--- PASS: TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions (57.87s)

@gdavison gdavison requested a review from a team as a code owner July 19, 2024 20:48
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/L Managed by automation to categorize the size of a PR. labels Jul 19, 2024
@gdavison
Copy link
Contributor Author

No CHANGELOG needed since function_schema hasn't been released yet

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit self-assigned this Jul 19, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrockAgentAgentActionGroup_' PKG=bedrockagent ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/bedrockagent/... -v -count 1 -parallel 3  -run=TestAccBedrockAgentAgentActionGroup_ -timeout 360m
=== RUN   TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN   TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== PAUSE TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== RUN   TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN   TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== PAUSE TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== RUN   TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== CONT  TestAccBedrockAgentAgentActionGroup_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== CONT  TestAccBedrockAgentAgentActionGroup_update
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (31.14s)
=== CONT  TestAccBedrockAgentAgentActionGroup_APISchema_s3
--- PASS: TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions (43.06s)
=== CONT  TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
--- PASS: TestAccBedrockAgentAgentActionGroup_update (50.79s)
--- PASS: TestAccBedrockAgentAgentActionGroup_APISchema_s3 (32.25s)
--- PASS: TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl (28.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	76.631s

@gdavison gdavison merged commit c4acee3 into main Jul 19, 2024
47 checks passed
@gdavison gdavison deleted the b-bedrockagent-function-tagged-union branch July 19, 2024 21:22
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 19, 2024
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants