Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3control_access_grants_instance: AWS IAM Identity Center integration #34582

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 27, 2023

Description

Adds the identity_center_arn argument and identity_center_application_arn attribute to aws_s3control_access_grants_instance to support AWS IAM Identity Center integration.

Relations

Closes #34578.
Relates #34556.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial/^Instance$$' PKG=s3control 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccessGrants_serial/^Instance$ -timeout 360m
=== RUN   TestAccS3ControlAccessGrants_serial
=== PAUSE TestAccS3ControlAccessGrants_serial
=== CONT  TestAccS3ControlAccessGrants_serial
=== RUN   TestAccS3ControlAccessGrants_serial/Instance
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/basic
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/disappears
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/tags
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/identityCenter
--- PASS: TestAccS3ControlAccessGrants_serial (169.04s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Instance (169.04s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (23.60s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (17.37s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/tags (58.04s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/identityCenter (70.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	174.504s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Nov 27, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3control Issues and PRs that pertain to the s3control service. service/identitystore Issues and PRs that pertain to the identitystore service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. labels Nov 27, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 27, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial/^Instance$$' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccessGrants_serial/^Instance$ -timeout 360m
=== RUN   TestAccS3ControlAccessGrants_serial
=== PAUSE TestAccS3ControlAccessGrants_serial
=== CONT  TestAccS3ControlAccessGrants_serial
=== RUN   TestAccS3ControlAccessGrants_serial/Instance
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/basic
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/disappears
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/tags
=== RUN   TestAccS3ControlAccessGrants_serial/Instance/identityCenter
--- PASS: TestAccS3ControlAccessGrants_serial (234.17s)
    --- PASS: TestAccS3ControlAccessGrants_serial/Instance (234.17s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (29.29s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (23.77s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/tags (73.09s)
        --- PASS: TestAccS3ControlAccessGrants_serial/Instance/identityCenter (108.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  237.313s

@ewbankkit ewbankkit merged commit c248e41 into main Nov 28, 2023
44 checks passed
@ewbankkit ewbankkit deleted the f-aws_s3control_access_grants_instance.identity_center_arn branch November 28, 2023 15:00
@github-actions github-actions bot added this to the v5.28.0 milestone Nov 28, 2023
github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
Copy link

This functionality has been released in v5.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/identitystore Issues and PRs that pertain to the identitystore service. service/s3control Issues and PRs that pertain to the s3control service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_s3control_access_grants_instance: AWS IAM Identity Center integration
2 participants