Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3(control): Complete migration to AWS SDK for Go v2 #33654

Closed
ewbankkit opened this issue Sep 27, 2023 · 6 comments · Fixed by #35035
Closed

s3(control): Complete migration to AWS SDK for Go v2 #33654

ewbankkit opened this issue Sep 27, 2023 · 6 comments · Fixed by #35035
Labels
service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 27, 2023

Complete the migration of the S3 and S3 Control resources and data sources to AWS SDK for Go v2.
The following are blocked from migration pending resolution of aws/aws-sdk-go-v2#2162:

  • aws_s3_account_public_access_block resource and data source
  • aws_s3_bucket resource
  • aws_s3_bucket_public_access_block resource
  • aws_s3_bucket_lifecycle_configuration resource
  • aws_s3_bucket_replication_configuration resource

Relates #33593.
Relates #33537.
Relates #33431.
Relates #33358.
Relates #33330.
Relates #33304.
Relates #33416.
Relates aws/aws-sdk-go-v2#2384.

aws_s3_bucket_lifecycle_configuration and aws_s3_bucket_replication_configuration can be be migrated by reverting 47f1924.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. labels Sep 27, 2023
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Sep 27, 2023
@ewbankkit
Copy link
Contributor Author

s3control should now be fully migratable -- aws/aws-sdk-go-v2#2333, #34096.

@ewbankkit
Copy link
Contributor Author

@ewbankkit
Copy link
Contributor Author

Just aws_s3_bucket remains -- will tackle after re:Invent.

Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant