-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_identitystore_group_memberships data source #31589
Add aws_identitystore_group_memberships data source #31589
Conversation
Community NoteVoting for Prioritization
For Submitters
|
I went with the arrays of each result attribute style from ssm_parameters_by_path vs one array for each result like they come from the API (ala iam_access_keys). Happy to switch if that wasn't the right call but I didn't see anything in the docs to prefer one over the other. I figured the majority of callers only care about the |
internal/service/identitystore/group_memberships_data_source.go
Outdated
Show resolved
Hide resolved
…roup_memberships-data-source
…roup_memberships-data-source
…roup_memberships-data-source
Migrated to the plugin framework as @aristosvo has done for #31681 / #36993, hopefully that helps it get merged. |
```console % make testacc PKG=identitystore TESTS=TestAccIdentityStoreGroupMembershipsDataSource_basic make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.7 test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroupMembershipsDataSource_basic' -timeout 360m -vet=off 2025/03/18 10:48:30 Initializing Terraform AWS Provider... --- PASS: TestAccIdentityStoreGroupMembershipsDataSource_basic (9.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/identitystore 15.892s ```
…ttribute spelling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=identitystore TESTS=TestAccIdentityStoreGroupMembershipsDataSource_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/identitystore/... -v -count 1 -parallel 20 -run='TestAccIdentityStoreGroupMembershipsDataSource_' -timeout 360m -vet=off
2025/03/18 11:20:38 Initializing Terraform AWS Provider...
=== RUN TestAccIdentityStoreGroupMembershipsDataSource_basic
=== PAUSE TestAccIdentityStoreGroupMembershipsDataSource_basic
=== CONT TestAccIdentityStoreGroupMembershipsDataSource_basic
--- PASS: TestAccIdentityStoreGroupMembershipsDataSource_basic (8.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/identitystore 15.523s
Thanks for your contribution, @liath 👍. I added handling for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Thanks @jar-b and @ewbankkit As for #31688, I imagine that will need the same changes as this |
This functionality has been released in v5.92.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds a data source for listing the members of an Identity Store Group. Part of a few PRs to cover #26770.
Relations
Relates #26770
References
https://docs.aws.amazon.com/cli/latest/reference/identitystore/list-group-memberships.html
https://docs.aws.amazon.com/singlesignon/latest/IdentityStoreAPIReference/API_ListGroupMemberships.html
Output from Acceptance Testing