Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AWSClient.S3ConnURICleaningDisabled #31501

Closed
ewbankkit opened this issue May 19, 2023 · 4 comments · Fixed by #31641
Closed

Remove AWSClient.S3ConnURICleaningDisabled #31501

ewbankkit opened this issue May 19, 2023 · 4 comments · Fixed by #31641
Labels
service/s3 Issues and PRs that pertain to the s3 service. upstream Addresses functionality related to the cloud provider.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented May 19, 2023 •
edited

aws/aws-sdk-go#4832 deprecates the AWS SDK for Go v1 config.DisableRestProtocolURICleaning, used by AWSClient.S3ConnURICleaningDisabled.
Remove this custom S3 API client.

Relates #31474.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title Remove 'AWSClient.S3ConnURICleaningDisabled' Remove AWSClient.S3ConnURICleaningDisabled May 19, 2023
@ewbankkit ewbankkit added upstream Addresses functionality related to the cloud provider. service/s3 Issues and PRs that pertain to the s3 service. labels May 19, 2023
@ewbankkit ewbankkit mentioned this issue May 19, 2023
Merged
@ewbankkit
Copy link
Contributor Author

Remove suppression added in #31502.

@aajtodd
Copy link

aajtodd commented May 26, 2023

NOTE: This change was reverted in v1.44.267 as it introduced a breaking change. We do not recommend using v1.44.265 or v1.44.266 that contain this change.

@ewbankkit ewbankkit mentioned this issue May 30, 2023
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/s3 Issues and PRs that pertain to the s3 service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Milestone
No milestone
2 participants
@ewbankkit @aajtodd