Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos related to policy rewrite #29892

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

justinretzolk
Copy link
Member

@justinretzolk justinretzolk commented Mar 9, 2023

Description

This PR fixes a few more typos that were introduced in the recent large rewriting of IAM policies switching away from heredoc format.

Relations

Closes #29872
Closes #29858
Closes #29855

References

#29360
#29354
#29356

Output from Acceptance Testing

N/a, docs

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@justinretzolk justinretzolk added documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. service/appsync Issues and PRs that pertain to the appsync service. labels Mar 9, 2023
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Mar 9, 2023
@github-actions github-actions bot added the service/codebuild Issues and PRs that pertain to the codebuild service. label Mar 9, 2023
@gdavison gdavison self-assigned this Mar 9, 2023
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@gdavison gdavison merged commit 8c194c5 into main Mar 9, 2023
@gdavison gdavison deleted the d-policy-document-references branch March 9, 2023 23:09
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 9, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. service/codebuild Issues and PRs that pertain to the codebuild service. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants