Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_dms_endpoint: Deprecate s3_settings #29728

Merged
merged 3 commits into from Mar 1, 2023
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 28, 2023

Description

Relations

Closes #29725

References

Output from Acceptance Testing

% make t T=TestAccDMSEndpoint_S3 K=dms      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_S3'  -timeout 180m
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_key
=== PAUSE TestAccDMSEndpoint_S3_key
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== RUN   TestAccDMSEndpoint_S3_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyId
=== CONT  TestAccDMSEndpoint_S3_basic
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== CONT  TestAccDMSEndpoint_S3_SSEKMSKeyId
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
=== CONT  TestAccDMSEndpoint_S3_key
--- PASS: TestAccDMSEndpoint_S3_key (9.79s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (37.30s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyId (37.69s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyARN (37.97s)
--- PASS: TestAccDMSEndpoint_S3_basic (49.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	51.559s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR. labels Feb 28, 2023
@YakDriver YakDriver changed the title dms_endpoint: Deprecate dms_endpoint: Deprecate s3_settings Feb 28, 2023
@YakDriver YakDriver changed the title dms_endpoint: Deprecate s3_settings aws_dms_endpoint: Deprecate s3_settings Feb 28, 2023
@YakDriver YakDriver merged commit cd44b1c into main Mar 1, 2023
@YakDriver YakDriver deleted the d-deprecate-s3-settings branch March 1, 2023 03:35
@github-actions github-actions bot added this to the v4.57.0 milestone Mar 1, 2023
github-actions bot pushed a commit that referenced this pull request Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aws_dms_endpoint to indicate s3_settings are deprecated
1 participant