Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_transfer_workflow - add decrypt type #29692

Merged
merged 9 commits into from Mar 7, 2023

Conversation

bennylu2
Copy link
Contributor

Description

Add decrypt_step_details to steps

Relations

Closes #29606

References

https://aws.amazon.com/about-aws/whats-new/2022/12/aws-transfer-family-built-in-pgp-decryption-file-uploads/

Output from Acceptance Testing

make testacc TESTS='TestAccTransferWorkflow_basic' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransferWorkflow_basic'  -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (22.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   36.686s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/transfer Issues and PRs that pertain to the transfer service. labels Feb 28, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Feb 28, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 28, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2023
Acceptance test output:

% make testacc TESTARGS='-run=TestAccTransferWorkflow_basic' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransferWorkflow_basic -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (15.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	20.440s
Acceptance test output:

% make testacc TESTARGS='-run=TestAccTransferWorkflow_' PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3  -run=TestAccTransferWorkflow_ -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (15.92s)
=== RUN   TestAccTransferWorkflow_onExceptionSteps
--- PASS: TestAccTransferWorkflow_onExceptionSteps (14.72s)
=== RUN   TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (14.33s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (33.73s)
=== RUN   TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (10.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	94.614s
Acceptance test output:

% make testacc TESTARGS='-run=TestAccTransferWorkflow_allSteps' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransferWorkflow_allSteps -timeout 180m
=== RUN   TestAccTransferWorkflow_allSteps
--- PASS: TestAccTransferWorkflow_allSteps (45.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	50.770s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransferWorkflow_' PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3  -run=TestAccTransferWorkflow_ -timeout 180m
=== RUN   TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (15.94s)
=== RUN   TestAccTransferWorkflow_onExceptionSteps
--- PASS: TestAccTransferWorkflow_onExceptionSteps (16.02s)
=== RUN   TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (15.83s)
=== RUN   TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (36.66s)
=== RUN   TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (11.09s)
=== RUN   TestAccTransferWorkflow_allSteps
--- PASS: TestAccTransferWorkflow_allSteps (36.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	136.824s

@ewbankkit
Copy link
Contributor

@bennylu2 Thanks for the contribution 🎉 👏.
Everything was great. I went ahead and added the same decrypt_step_details to on_exception_steps.

@ewbankkit ewbankkit merged commit 8b8b745 into hashicorp:main Mar 7, 2023
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 7, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_transfer_workflow doesn't have decrypt type
2 participants