r/db_snapshot - add support for sharing snapshots

[DrFaust92]

Description

also minor refactor for better reuse of code

Relations

Closes #3860

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRDSSnapshot_  PKG=rds

--- PASS: TestAccRDSSnapshot_basic (579.00s)
--- PASS: TestAccRDSSnapshot_share (595.28s)
--- PASS: TestAccRDSSnapshot_disappears (703.36s)
--- PASS: TestAccRDSSnapshot_tags (832.48s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSnapshot_\|TestAccRDSSnapshotCopy_ -timeout 180m
=== RUN   TestAccRDSSnapshotCopy_basic
=== PAUSE TestAccRDSSnapshotCopy_basic
=== RUN   TestAccRDSSnapshotCopy_tags
=== PAUSE TestAccRDSSnapshotCopy_tags
=== RUN   TestAccRDSSnapshotCopy_disappears
=== PAUSE TestAccRDSSnapshotCopy_disappears
=== RUN   TestAccRDSSnapshot_basic
=== PAUSE TestAccRDSSnapshot_basic
=== RUN   TestAccRDSSnapshot_share
=== PAUSE TestAccRDSSnapshot_share
=== RUN   TestAccRDSSnapshot_tags
=== PAUSE TestAccRDSSnapshot_tags
=== RUN   TestAccRDSSnapshot_disappears
=== PAUSE TestAccRDSSnapshot_disappears
=== CONT  TestAccRDSSnapshotCopy_basic
=== CONT  TestAccRDSSnapshot_share
=== CONT  TestAccRDSSnapshotCopy_disappears
--- PASS: TestAccRDSSnapshotCopy_basic (628.93s)
=== CONT  TestAccRDSSnapshot_basic
--- PASS: TestAccRDSSnapshot_share (780.29s)
=== CONT  TestAccRDSSnapshotCopy_tags
--- PASS: TestAccRDSSnapshotCopy_disappears (858.69s)
=== CONT  TestAccRDSSnapshot_disappears
--- PASS: TestAccRDSSnapshot_basic (729.37s)
=== CONT  TestAccRDSSnapshot_tags
--- PASS: TestAccRDSSnapshot_disappears (707.80s)
--- PASS: TestAccRDSSnapshotCopy_tags (840.43s)
--- PASS: TestAccRDSSnapshot_tags (763.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2126.834s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.