Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/3.x: Backport #25768; Remove Computed from apply_immediately #28298

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 12, 2022

Description

Backports #25768 to release/3.x.

Relations

Relates #25711.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSInstance_basic\|TestAccRDSInstance_identifierGenerated\|TestAccRDSInstance_subnetGroup' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstance_basic\|TestAccRDSInstance_identifierGenerated\|TestAccRDSInstance_subnetGroup -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_subnetGroup
=== PAUSE TestAccRDSInstance_subnetGroup
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_subnetGroup
--- PASS: TestAccRDSInstance_basic (528.91s)
--- PASS: TestAccRDSInstance_subnetGroup (920.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	924.101s

fdmsantos and others added 4 commits December 12, 2022 09:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Dec 12, 2022
@kwilczynski
Copy link
Contributor

@ewbankkit, thank you! 🙇

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 12, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 12, 2022
@ewbankkit ewbankkit merged commit d310aed into release/3.x Dec 12, 2022
@ewbankkit ewbankkit deleted the release/3.x-25768 branch December 12, 2022 17:08
@github-actions github-actions bot added this to the v3.75.3 milestone Dec 12, 2022
github-actions bot pushed a commit that referenced this pull request Dec 12, 2022
@github-actions
Copy link

This functionality has been released in v3.76.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants