Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport nodejs16.x support for aws_lambda_function to v3.x #24874

Merged
merged 7 commits into from
May 19, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24873.
Relates #24768.

% make testacc TESTARGS='-run=TestAccLambdaFunction_runtimes\|TestAccLambdaFunction_envVariables' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_runtimes\|TestAccLambdaFunction_envVariables -timeout 180m
=== RUN   TestAccLambdaFunction_envVariables
=== PAUSE TestAccLambdaFunction_envVariables
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== CONT  TestAccLambdaFunction_envVariables
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_envVariables (114.52s)
--- PASS: TestAccLambdaFunction_runtimes (436.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	440.364s
TODO

Add CHANGELOG entry to #24346 after merge.

ewbankkit added 6 commits May 19, 2022 09:24
…onment' must be checked by element count key (environment.#) or element value keys (e.g. environment.0).'.
…he runtime parameter of dotnetcore2.1 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (dotnet6) while creating or updating functions.'.
@github-actions github-actions bot added service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels May 19, 2022
@ewbankkit ewbankkit added this to the v3.75.2 milestone May 19, 2022
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label May 19, 2022
@ewbankkit ewbankkit merged commit e67ca7b into release/3.x May 19, 2022
@ewbankkit ewbankkit deleted the f-aws_lambda_function-nodejs16.x-3.x branch May 19, 2022 17:14
github-actions bot pushed a commit that referenced this pull request May 19, 2022
@github-actions
Copy link

This functionality has been released in v3.75.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants