-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: hashicorp/terraform-provider-aws
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.94.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: hashicorp/terraform-provider-aws
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.94.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 5 files changed
- 5 contributors
Commits on Apr 3, 2025
-
Configuration menu - View commit details
-
Copy full SHA for f8e746d - Browse repository at this point
Copy the full SHA f8e746dView commit details -
Update CHANGELOG.md after v5.94.0
changelogbot committedApr 3, 2025 Loading Loading status checks…Configuration menu - View commit details
-
Copy full SHA for 647764f - Browse repository at this point
Copy the full SHA 647764fView commit details -
Merge pull request #42111 from hashicorp/s3tables_table_documentation
s3tables: Correctly identify arguments as objects rather than blocks
Configuration menu - View commit details
-
Copy full SHA for 535beb6 - Browse repository at this point
Copy the full SHA 535beb6View commit details -
r/aws_sns_topic_subscription: fix
AuthorizationError
for `ListSubsc……riptionByTopic` operations `v5.94.0` introduced an additional call to the `ListSubscriptionByTopic` API during the read operation to properly topic and subscription deletions which are only eventually consistent from the `GetSubscriptionAttributes` API. An unintended side effect of this addition was that existing principals which lack the appropriate IAM permissions to call `ListSubscriptionsByTopic` will observe apply time failures similar to: ``` AuthorizationError: User: arn:aws:sts::111111111111:assumed-role/abc123/terraform-run-V6rpqcU7sztpyrnS is not authorized to perform: SNS:ListSubscriptionsByTopic on resource: arn:aws:sns:us-west-2:222222222222:TopicName because no resource-based policy allows the SNS:ListSubscriptionsByTopic action ``` This change addresses the regression by skipping `AuthorizationError` exceptions rather than surfacing them as hard errors. The impact of ignoring these errors should be minimal, as the additional API call was only intended to catch eventual consistency edge cases that `GetSubscriptionAttributes` will still (eventually) catch. ```console % make testacc PKG=sns TESTS=TestAccSNSTopicSubscription_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.7 test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicSubscription_' -timeout 360m -vet=off 2025/04/03 15:52:40 Initializing Terraform AWS Provider... --- PASS: TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet (3.73s) --- PASS: TestAccSNSTopicSubscription_email (17.09s) --- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (41.72s) --- PASS: TestAccSNSTopicSubscription_disappears (50.27s) --- PASS: TestAccSNSTopicSubscription_disappears_TopicExternal (50.46s) --- PASS: TestAccSNSTopicSubscription_disappears_Topic (50.53s) --- PASS: TestAccSNSTopicSubscription_basic (52.11s) --- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (70.27s) --- PASS: TestAccSNSTopicSubscription_deliveryPolicy (70.86s) --- PASS: TestAccSNSTopicSubscription_filterPolicy (71.45s) --- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (85.36s) --- PASS: TestAccSNSTopicSubscription_firehose (95.70s) --- PASS: TestAccSNSTopicSubscription_redrivePolicy (104.99s) --- PASS: TestAccSNSTopicSubscription_filterPolicyScope (148.66s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sns 155.739s ```
Configuration menu - View commit details
-
Copy full SHA for 0556420 - Browse repository at this point
Copy the full SHA 0556420View commit details
Commits on Apr 4, 2025
-
Configuration menu - View commit details
-
Copy full SHA for de9cb22 - Browse repository at this point
Copy the full SHA de9cb22View commit details -
Merge pull request #42117 from hashicorp/b-sns-permission-regression
r/aws_sns_topic_subscription: ignore `AuthorizationError` for `ListSubscriptionByTopic` operations
Configuration menu - View commit details
-
Copy full SHA for 7b488c2 - Browse repository at this point
Copy the full SHA 7b488c2View commit details -
Update CHANGELOG.md for #42117
changelogbot committedApr 4, 2025 Loading Loading status checks…Configuration menu - View commit details
-
Copy full SHA for 19a2f07 - Browse repository at this point
Copy the full SHA 19a2f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce63258 - Browse repository at this point
Copy the full SHA ce63258View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.94.0...v5.94.1