Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/terraform-provider-aws
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.94.0
Choose a base ref
...
head repository: hashicorp/terraform-provider-aws
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.94.1
Choose a head ref
  • 8 commits
  • 5 files changed
  • 5 contributors

Commits on Apr 3, 2025

  1. Correctly identify arguments as objects rather than blocks

    justinretzolk committed Apr 3, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f8e746d View commit details
  2. Update CHANGELOG.md after v5.94.0

    changelogbot committed Apr 3, 2025
    Copy the full SHA
    647764f View commit details
  3. Merge pull request #42111 from hashicorp/s3tables_table_documentation

    s3tables: Correctly identify arguments as objects rather than blocks
    justinretzolk authored Apr 3, 2025
    Copy the full SHA
    535beb6 View commit details
  4. r/aws_sns_topic_subscription: fix AuthorizationError for `ListSubsc…

    …riptionByTopic` operations
    
    `v5.94.0` introduced an additional call to the `ListSubscriptionByTopic` API during the read operation to properly  topic and subscription deletions which are only eventually consistent from the `GetSubscriptionAttributes` API. An unintended side effect of this addition was that existing principals which lack the appropriate IAM permissions to call `ListSubscriptionsByTopic` will observe apply time failures similar to:
    
    ```
    AuthorizationError: User: arn:aws:sts::111111111111:assumed-role/abc123/terraform-run-V6rpqcU7sztpyrnS is not authorized to perform: SNS:ListSubscriptionsByTopic on resource: arn:aws:sns:us-west-2:222222222222:TopicName because no resource-based policy allows the SNS:ListSubscriptionsByTopic action
    ```
    
    This change addresses the regression by skipping `AuthorizationError` exceptions rather than surfacing them as hard errors. The impact of ignoring these errors should be minimal, as the additional API call was only intended to catch eventual consistency edge cases that `GetSubscriptionAttributes` will still (eventually) catch.
    
    ```console
    % make testacc PKG=sns TESTS=TestAccSNSTopicSubscription_
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.23.7 test ./internal/service/sns/... -v -count 1 -parallel 20 -run='TestAccSNSTopicSubscription_'  -timeout 360m -vet=off
    2025/04/03 15:52:40 Initializing Terraform AWS Provider...
    
    --- PASS: TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet (3.73s)
    --- PASS: TestAccSNSTopicSubscription_email (17.09s)
    --- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (41.72s)
    --- PASS: TestAccSNSTopicSubscription_disappears (50.27s)
    --- PASS: TestAccSNSTopicSubscription_disappears_TopicExternal (50.46s)
    --- PASS: TestAccSNSTopicSubscription_disappears_Topic (50.53s)
    --- PASS: TestAccSNSTopicSubscription_basic (52.11s)
    --- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (70.27s)
    --- PASS: TestAccSNSTopicSubscription_deliveryPolicy (70.86s)
    --- PASS: TestAccSNSTopicSubscription_filterPolicy (71.45s)
    --- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (85.36s)
    --- PASS: TestAccSNSTopicSubscription_firehose (95.70s)
    --- PASS: TestAccSNSTopicSubscription_redrivePolicy (104.99s)
    --- PASS: TestAccSNSTopicSubscription_filterPolicyScope (148.66s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        155.739s
    ```
    jar-b committed Apr 3, 2025
    Copy the full SHA
    0556420 View commit details

Commits on Apr 4, 2025

  1. Update .changelog/42117.txt

    ewbankkit authored Apr 4, 2025
    Copy the full SHA
    de9cb22 View commit details
  2. Merge pull request #42117 from hashicorp/b-sns-permission-regression

    r/aws_sns_topic_subscription: ignore `AuthorizationError` for `ListSubscriptionByTopic` operations
    nam054 authored Apr 4, 2025
    Copy the full SHA
    7b488c2 View commit details
  3. Update CHANGELOG.md for #42117

    changelogbot committed Apr 4, 2025
    Copy the full SHA
    19a2f07 View commit details
  4. Patch release changelog (#42132)

    nam054 authored Apr 4, 2025
    Copy the full SHA
    ce63258 View commit details
Loading