Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small edit for style on a code comment #975

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

rkoron007
Copy link
Contributor

Making the the code comment language match the changes from a recent tutorial PR: https://github.com/hashicorp/tutorials/pull/1945

@rkoron007 rkoron007 requested a review from a team as a code owner April 3, 2024 17:12
@rkoron007 rkoron007 added the documentation Improvements or additions to documentation label Apr 3, 2024
Copy link
Contributor

@robin-norwood robin-norwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making the PR!

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, thanks for the update 🙂

website/docs/plugin/framework/data-sources/configure.mdx Outdated Show resolved Hide resolved
website/docs/plugin/framework/resources/configure.mdx Outdated Show resolved Hide resolved
Co-authored-by: Austin Valle <austinvalle@gmail.com>
@austinvalle austinvalle merged commit 541a7cb into main Apr 4, 2024
3 checks passed
@austinvalle austinvalle deleted the RK/provider-nil-check-style branch April 4, 2024 13:14
Copy link

github-actions bot commented May 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants