adds support for ephemeral resources #157
Merged
+743
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@austinvalle 👋 Could you give this a look and approve the workflow runs when you get a chance? Thanks! |
austinvalle
force-pushed
the
ephemeral-resource
branch
from
7f0cc12 to
ccf1250
Compare
austinvalle
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Hey there @marshallford 👋🏻 , thanks for the PR!
Overall everything LGTM here, we just need a changelog to go with it, if you want to push one to the branch.
Once that's there I can release this in v0.5.0
austinvalle
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋🏼 . I took an initial swing at this, mostly using the
datasource/timeoutsimplementation as my reference. From what I can tell datasources and ephemeral resources are similar in that they each only have a single lifecycle where the terraform configuration is provided in the request (readandopenrespectively). I am a bit confused why the terraform configuration isn't available as a part of the request for ephemeral's additional lifecycles (renewandclose), but that's a seperate question altogether.Fixes #156.