Checks: instance_key should be of type interface{} #94
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasslash
force-pushed
the
sebasslash/invalid-instance-key-type
branch
from
ab83c2a to
441668c
Compare
sebasslash
force-pushed
the
sebasslash/invalid-instance-key-type
branch
from
441668c to
614de2a
Compare
liamcervante
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when unmarshalling a JSON plan containing checks, where
instance_keyfields are a number rather than a string. An instance key can be either a string or a number, so this PR changes the type to beinterface{}and adds a test to ensure that the instance key is one of those two valid types.