Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-commit hook and add GHA dependabot config for managing hashicorp actions #393

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

austinvalle
Copy link
Member

Ref: https://github.com/hashicorp/terraform-providers-devex-internal/issues/174

(The pre-commit hook was really fighting my script and it doesn't seem necessary since we have CI already on PRs 🙂 )

@austinvalle austinvalle requested a review from a team as a code owner January 31, 2024 14:01
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've come to doing the same locally regarding the pre-commit script, so 👍 from me there. We should take a look at the rest of the husky usage in this codebase and decide if its necessary.

@austinvalle
Copy link
Member Author

I'll do that in a separate PR while it's fresh of mind 👍🏻

@austinvalle austinvalle merged commit e12a014 into main Jan 31, 2024
67 checks passed
@austinvalle austinvalle deleted the av/dependabot-hc branch January 31, 2024 14:24
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants