-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to disable dmidecode #25108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @jorgemarey! I've left a few small comments but once those are resolved this should be good to merge. I've also pulled down this branch and built locally for testing.
Without cpu_disable_dmidecode
set:
$ sudo execsnoop.bt | grep dmidecode
10:21:00.480806 218150 218128 /usr/sbin/dmidecode -t 4
$ nomad operator api /v1/agent/self | jq '.config.Client.CpuDisableDmidecode'
false
With cpu_disable_dmidecode = true
:
$ $ sudo execsnoop.bt | grep dmidecode
^C
$ nomad operator api /v1/agent/self | jq '.config.Client.CpuDisableDmidecode'
true
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgemarey Thank you for updating the docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll merge this once CI is green and get it backported to the 1.9.x series. Thanks @jorgemarey!
Fixes #19468