Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable dmidecode #25108

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

jorgemarey
Copy link
Contributor

Fixes #19468

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @jorgemarey! I've left a few small comments but once those are resolved this should be good to merge. I've also pulled down this branch and built locally for testing.

Without cpu_disable_dmidecode set:

$ sudo execsnoop.bt | grep dmidecode
10:21:00.480806 218150  218128  /usr/sbin/dmidecode -t 4

$ nomad operator api /v1/agent/self |  jq '.config.Client.CpuDisableDmidecode'
false

With cpu_disable_dmidecode = true:

$ $ sudo execsnoop.bt | grep dmidecode
^C

$ nomad operator api /v1/agent/self | jq '.config.Client.CpuDisableDmidecode'
true

👍

@tgross tgross added this to the 1.9.x milestone Feb 13, 2025
@tgross tgross added the backport/1.9.x backport to 1.9.x release line label Feb 13, 2025
@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label Feb 13, 2025
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgemarey Thank you for updating the docs!

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll merge this once CI is green and get it backported to the 1.9.x series. Thanks @jorgemarey!

@tgross tgross merged commit 25426f0 into hashicorp:main Feb 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line theme/docs Documentation issues and enhancements theme/fingerprint theme/platform-linux type/enhancement
Projects
Development

Successfully merging this pull request may close these issues.

config option to specify CPU fingerprinting fallback (dmidecode may be suboptimal)
3 participants