From 818d7bdf17525d54ff546abb9a0735d61df8c90b Mon Sep 17 00:00:00 2001 From: Dmitry Verkhoturov Date: Wed, 19 Apr 2023 09:22:18 +0200 Subject: [PATCH] fix benchmarks hit ratio display Was previously dividing hit by miss, should be dividing hit by total. --- 2q_test.go | 4 ++-- arc_test.go | 4 ++-- lru_test.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/2q_test.go b/2q_test.go index 73ef89b..fd4c0e9 100644 --- a/2q_test.go +++ b/2q_test.go @@ -32,7 +32,7 @@ func Benchmark2Q_Rand(b *testing.B) { } } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func Benchmark2Q_Freq(b *testing.B) { @@ -63,7 +63,7 @@ func Benchmark2Q_Freq(b *testing.B) { miss++ } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func Test2Q_RandomOps(t *testing.T) { diff --git a/arc_test.go b/arc_test.go index 1eafdbd..7171d41 100644 --- a/arc_test.go +++ b/arc_test.go @@ -38,7 +38,7 @@ func BenchmarkARC_Rand(b *testing.B) { } } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func BenchmarkARC_Freq(b *testing.B) { @@ -69,7 +69,7 @@ func BenchmarkARC_Freq(b *testing.B) { miss++ } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func TestARC_RandomOps(t *testing.T) { diff --git a/lru_test.go b/lru_test.go index 42f8e1d..3081a5b 100644 --- a/lru_test.go +++ b/lru_test.go @@ -32,7 +32,7 @@ func BenchmarkLRU_Rand(b *testing.B) { } } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func BenchmarkLRU_Freq(b *testing.B) { @@ -63,7 +63,7 @@ func BenchmarkLRU_Freq(b *testing.B) { miss++ } } - b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(miss)) + b.Logf("hit: %d miss: %d ratio: %f", hit, miss, float64(hit)/float64(hit+miss)) } func TestLRU(t *testing.T) {