Add rotation and a few related helper functions #7
+630
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was pulled out of Vault's codebase, then enhanced to split different parts of it into different functions. This also introduces the option pattern. The rotation test validates creation and deletion independently as well as the combination via the rotate function. Coverage (when running with real AWS creds) is mostly green for all added code, except for places where we are handling exceptional conditions from AWS' API.
vancluever
previously approved these changes
Sep 2, 2021
calvn
reviewed
Sep 2, 2021
vancluever
previously approved these changes
Sep 2, 2021
calvn
reviewed
Sep 2, 2021
calvn
previously approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pulled out of Vault's codebase, then enhanced to split
different parts of it into different functions. This also introduces the
option pattern. The rotation test validates creation and deletion
independently as well as the combination via the rotate function.
Coverage (when running with real AWS creds) is mostly green for all
added code, except for places where we are handling exceptional
conditions from AWS' API.