Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some pretty quick-and-easy wins for performance in the strutil package.
Use
struct{}
instead ofbool
for map membership. The empty struct does not allocate and consumes no memory, so it's far more efficient than a boolean:Pre-allocate slices and maps when we know the maximum possible size.
Remove an unnecessary test dependency and rename the tests to match Go's expected test format name.
Benchmarks
Before:
After: