New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlock: Remove android build tag #16

Merged

jefferai merged 1 commit into hashicorp:main from paulburlumi:dev/mlock_fix_android

Nov 22, 2021

Contributor

paulburlumi commented Nov 1, 2021

Using GOOS=android matches build tags and files as for GOOS=linux in addition to android tags and files.
See https://groups.google.com/g/golang-nuts/c/ZTGMjhEV7uY for further details.

Without this change when using gomobile bind I see the following error:

# github.com/hashicorp/go-secure-stdlib/mlock
../pkg/mod/github.com/hashicorp/go-secure-stdlib/mlock@v0.1.1/mlock_unix.go:15:6: lockMemory redeclared in this block
        /tmp/gomobile-work-2337392267/pkg/mod/github.com/hashicorp/go-secure-stdlib/mlock@v0.1.1/mlock_unavail.go:9:19: previous declaration


          Remove android build tag

82a7cec

paulburlumi changed the title ~~Remove android build tag~~ mlock: Remove android build tag

jefferai approved these changes

View reviewed changes

Member

jefferai left a comment

Looks good, thanks!

jefferai merged commit 002fddc into hashicorp:main

paulburlumi deleted the dev/mlock_fix_android branch

November 23, 2021 17:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment