Add day suffix support to ParseDurationSecond #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a "d" suffix that corresponds to 24 hours. Also add more test cases and slightly refactor the code.
calvn
reviewed
Oct 21, 2021
calvn
reviewed
Oct 21, 2021
calvn
reviewed
Oct 21, 2021
jasonodonnell
previously approved these changes
Oct 21, 2021
ncabatoff
reviewed
Oct 21, 2021
ncabatoff
previously approved these changes
Oct 21, 2021
calvn
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a "d" suffix that corresponds to 24 hours. Also add more test cases and slightly refactor the code.
This type of support has been requested and rejected by the Go team (golang/go#11473). Their push back was around "how long is a day?", but for our users I think defining a day as 24 hours is fine, and convenient for longer duration TTLs, e.g. root keys that are valid for 90 days.