Cherry-pick another upstream v1.4.1 change #9
+74
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 92d5fa8.
When converting a list of objects, it is necessary to unify the types of the child elements.
Previously, we checked if two sets had the same rules using a simple equality check. This panics if the sets contain object types, as they cannot be compared using `==`. Adding a SameRules method to the Rules interface allows us to delegate to the Type.Equals method where necessary, fixing this problem.
If one or more arguments to the stdlib set functions was an empty set of dynamic pseudo type, the functions would panic due to incompatible set rules. We can special case empty dynamic pseudo type sets to be ignored through type unification, because they are always capable of being converted to any other type.
austinvalle
approved these changes
Mar 6, 2025
| @@ -5,7 +5,7 @@ import ( | |||
| "math/big" | |||
| "testing" | |||
|
|
|||
| "github.com/zclconf/go-cty/cty/set" | |||
| "github.com/hashicorp/go-cty/cty/set" | |||
bbasata
added a commit
to hashicorp/terraform-plugin-sdk
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed an upstream commit in #7 -- this pull request adds it.
How I missed it: on the first run, I collected commits from upstream using:
and I supplied that list to
git cherry-pick. Better: