Fix incorrect protocol check on discovery chains with peer targets. #15833
+109
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following message is incorrectly printed out whenever saving a service-resolver with a peer failover target.
discovery chain "my-chain" uses inconsistent protocols; service "my-service" has "tcp" which is not "http"
This PR excludes peer targets from the protocol validation logic when building discovery chains, which should prevent the error from occurring.
Steps to reproduce:
Be careful to ensure that no "myremote" service-default exists in the local cluster, as it will actually be looked up, and the error will not surface.