Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add VLAN network for VM to support multiple or all VLANID #766

Open
yaocw2020 opened this issue Apr 26, 2021 · 10 comments
Open

[FEATURE] Add VLAN network for VM to support multiple or all VLANID #766

yaocw2020 opened this issue Apr 26, 2021 · 10 comments
Assignees
Labels
area/network kind/enhancement Issues that improve or augment existing functionality need-reprioritize priority/2 Nice to fix in this release
Milestone

Comments

@yaocw2020
Copy link
Contributor

yaocw2020 commented Apr 26, 2021

Is your feature request related to a problem? Please describe.

When building Harvester in Harvester, the inner Harvester's VLAN network will be ineffective, because the veth on the host end (outer Harvester host) only allows package with only one VLAN tag.

Describe the solution you'd like

There are two possible solutions.

  • Modify bridge CNI to support multiple VLAN ID.
  • Add an additional parameter in VLAN configuration for Harvester-network-controller to allow multiple VLAN ID.

Describe alternatives you've considered

Additional context

@yaocw2020 yaocw2020 added the kind/enhancement Issues that improve or augment existing functionality label Apr 26, 2021
@futuretea
Copy link
Contributor

Using ovs instead of bridge seems better

@yaocw2020 yaocw2020 added this to the v0.3.0 milestone Apr 26, 2021
@yaocw2020 yaocw2020 self-assigned this Apr 26, 2021
@guangbochen guangbochen added area/network priority/2 Nice to fix in this release labels May 6, 2021
@yaocw2020
Copy link
Contributor Author

Harvester in Harvester can‘t also support bond.

@guangbochen guangbochen modified the milestones: v0.3.0, v1.1.0 Sep 27, 2021
@tjjh89017 tjjh89017 self-assigned this Jan 11, 2022
@tjjh89017
Copy link
Contributor

Note:
after checking linux bridge kernel code [1], while vlan_filtering is disable, it will transfer all traffic to destination port
(include vlan tagged packet)
Kubevirt also disable mac learning in bridge inside Pod [2], so we can consider the network inside Pod is L1 transparent network.

once CNI bridge accept the patch[3] to support vlan trunk, and we can start to patch network-controller to support vlan networks

[1] https://elixir.bootlin.com/linux/latest/source/net/bridge/br_vlan.c#L601
[2] https://github.com/kubevirt/kubevirt/blob/main/pkg/network/infraconfigurators/bridge.go#L151
[3] containernetworking/plugins#689

@pandalec
Copy link

Any news regarding this? It would be nice to have an option like VMware's VLANID 4095

@tjjh89017
Copy link
Contributor

Any news regarding this? It would be nice to have an option like VMware's VLANID 4095

Currently, Bridge CNI Plugin didn't support VLAN trunk mode for Pods.
So it should wait for that issue first.

@pandalec
Copy link

Any news regarding this? It would be nice to have an option like VMware's VLANID 4095

Currently, Bridge CNI Plugin didn't support VLAN trunk mode for Pods. So it should wait for that issue first.

ovs would support it, like @futuretea mentioned

@tjjh89017
Copy link
Contributor

Any news regarding this? It would be nice to have an option like VMware's VLANID 4095

Currently, Bridge CNI Plugin didn't support VLAN trunk mode for Pods. So it should wait for that issue first.

ovs would support it, like @futuretea mentioned

It will take some effort to change CNI plugin.
We will discuss these in the future.
Thanks for comment

@pandalec
Copy link

It will take some effort to change CNI plugin. We will discuss these in the future. Thanks for comment

Thank you!

@guangbochen
Copy link
Contributor

The upstream bridge PR containernetworking/plugins#829 is merged, we may continue our investigation about this, thanks.

@guangbochen guangbochen modified the milestones: v1.2.0, v1.2.1 May 10, 2023
@w13915984028 w13915984028 modified the milestones: v1.2.2, v1.4.0 Mar 18, 2024
@ER-EPR
Copy link

ER-EPR commented Mar 21, 2024

Hope this could be implemented soon, now my opnsense dhcp is a mess. The dhcp on one port is able to reach clients connected through other ports, as if they were internally connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/network kind/enhancement Issues that improve or augment existing functionality need-reprioritize priority/2 Nice to fix in this release
Projects
None yet
Development

No branches or pull requests

8 participants