Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: %Z format string not supported correctly #684

Closed
domdomegg opened this issue Apr 18, 2024 · 0 comments
Closed

bug: %Z format string not supported correctly #684

domdomegg opened this issue Apr 18, 2024 · 0 comments
Labels

Comments

@domdomegg
Copy link

Problem

The date docs suggest LiquidJS supports Ruby format flags, including the %Z flag for timezone name (given this is not in the list of differences).

However, LiquidJS does not appear to support this.

Demo

Demo: https://liquidjs.com/playground.html#e3sgIjIwMjQtMDQtMjlUMDk6MDA6MDAuMDAwWiIgfCBkYXRlOiAiJUk6JU0lUCAlWiIgfX0=,e30=

{{ "2024-04-29T09:00:00.000Z" | date: "%I:%M%P %Z" }}

Suggested solutions

  1. Support %Z flag (preferred)
  2. Explicitly list it as a incompatibility in the docs
@harttle harttle added the bug label Apr 18, 2024
github-actions bot pushed a commit that referenced this issue Apr 21, 2024
## [10.11.1](v10.11.0...v10.11.1) (2024-04-21)

### Bug Fixes

* allow %Z for TimezoneDate, update docs accordingly [#684](#684) ([e09657c](e09657c))
* Allow `lenientIf` for multiple operands (issue [#682](#682)) ([#683](#683)) ([490ff43](490ff43))
@harttle harttle closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants