Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Array sum filter #661

Merged
merged 3 commits into from Dec 19, 2023

Conversation

brunodccarvalho
Copy link
Contributor

Implement sum filter from shopify liquid. Fixes #660
Note the last two tests assert incompatibility with the ruby version, in particular coercing of true

@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7261528445

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.468%

Totals Coverage Status
Change from base Build 7033554616: 0.002%
Covered Lines: 2243
Relevant Lines: 2250

💛 - Coveralls

@brunodccarvalho brunodccarvalho changed the title Array sum filter ruby liquid feat: Array sum filter ruby liquid Dec 18, 2023
@brunodccarvalho brunodccarvalho changed the title feat: Array sum filter ruby liquid feat: Array sum filter Dec 18, 2023
docs/source/filters/sum.md Outdated Show resolved Hide resolved
@harttle harttle merged commit 629d958 into harttle:master Dec 19, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
# [10.10.0](v10.9.4...v10.10.0) (2023-12-19)

### Features

* Array sum filter ([#661](#661)) ([629d958](629d958))
Copy link

🎉 This PR is included in version 10.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@harttle
Copy link
Owner

harttle commented Dec 19, 2023

@all-contributors please add @brunodccarvalho for code.

Copy link
Contributor

@harttle

I've put up a pull request to add @brunodccarvalho! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array sum filter
3 participants