fix(stack): don't warn for localhost in development (#51)

dargmuesli · web-flow · commit d3e100dc1cd4 · 2025-03-19T04:25:08.000+11:00
diff --git a/packages/site-config/src/stack.ts b/packages/site-config/src/stack.ts
@@ -40,7 +40,7 @@ export function validateSiteConfigStack(stack: SiteConfigStack) {
       errors.push(`url "${val}" from ${context} should not contain a hash`)
     else if (Object.keys(getQuery(val)).length > 0)
       errors.push(`url "${val}" from ${context} should not contain a query`)
-    else if (url.host === 'localhost')
+    else if (url.host === 'localhost' && resolved.env !== 'development')
       errors.push(`url "${val}" from ${context} should not be localhost`)
   }
   return errors

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export function validateSiteConfigStack(stack: SiteConfigStack) {`
`40`	`40`	errors.push(`url "${val}" from ${context} should not contain a hash`)
`41`	`41`	`else if (Object.keys(getQuery(val)).length > 0)`
`42`	`42`	errors.push(`url "${val}" from ${context} should not contain a query`)
`43`		`- else if (url.host === 'localhost')`
	`43`	`+ else if (url.host === 'localhost' && resolved.env !== 'development')`
`44`	`44`	errors.push(`url "${val}" from ${context} should not be localhost`)
`45`	`45`	`}`
`46`	`46`	`return errors`