Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subset] instancer-solver crossing calculation fix #4289

Closed
behdad opened this issue Jun 21, 2023 · 3 comments
Closed

[subset] instancer-solver crossing calculation fix #4289

behdad opened this issue Jun 21, 2023 · 3 comments
Assignees
@qxliu76

Comments

@behdad
Copy link
Member

behdad commented Jun 21, 2023

This commit:
fonttools/fonttools@023ad3a

from this larger PR, that I'll file a separate issue for:
fonttools/fonttools#3179
@behdad
Copy link
Member Author

behdad commented Jun 21, 2023

I pushed the fix, but not the tests.

@behdad behdad closed this as completed in de0c5ae Jun 21, 2023
@behdad behdad reopened this Jun 21, 2023
@behdad
Copy link
Member Author

behdad commented Jun 21, 2023

@qxliu76 Can you add the tests please?

@qxliu76
Copy link
Collaborator

qxliu76 commented Jun 22, 2023

sure, I'll work on it.

@qxliu76 qxliu76 mentioned this issue Jun 22, 2023
Merged
@behdad behdad closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qxliu76 qxliu76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @qxliu76