fix: fix error for each helper with block params and strict mode #1820 #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturmakaranka
changed the title
arturmakaranka
changed the title
jaylinski
requested changes
May 6, 2022
jaylinski
approved these changes
May 10, 2022
|
@jaylinski can you please merge this fix? or how often it happens? As I understand I can't impact ot this process/ |
jaylinski
force-pushed
the
fix/block-params-for-each-helper-in-strict-mode
branch
from
1845af8
to
86a9615
Compare
|
ℹ️ This fix was added to |
3 tasks
|
@arturmakaranka Thank you for the fix! Very much appreciated. I'll try to release the fix as soon as possible, but it may take some time. |
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Mar 22, 2023
The fix at handlebars-lang/handlebars.js#1855 is not released yet. Signed-off-by: Anders Kaseorg <anders@zulip.com>
andersk
added a commit
to andersk/zulip
that referenced
this pull request
Mar 22, 2023
The fix at handlebars-lang/handlebars.js#1855 is not released yet. Signed-off-by: Anders Kaseorg <anders@zulip.com>
timabbott
pushed a commit
to timabbott/zulip
that referenced
this pull request
Mar 23, 2023
The fix at handlebars-lang/handlebars.js#1855 is not released yet. Signed-off-by: Anders Kaseorg <anders@zulip.com>
sbansal1999
pushed a commit
to sbansal1999/zulip
that referenced
this pull request
Apr 1, 2023
The fix at handlebars-lang/handlebars.js#1855 is not released yet. Signed-off-by: Anders Kaseorg <anders@zulip.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #each helper with params in strict mode. By the same pr of @jaylinski https://github.com/handlebars-lang/handlebars.js/pull/1821/files