Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.footer/.page-nav color contrast fails WCAG AA #51

Open
ghost opened this issue Jun 16, 2020 · 7 comments
Open

.footer/.page-nav color contrast fails WCAG AA #51

ghost opened this issue Jun 16, 2020 · 7 comments

Comments

@ghost
Copy link

ghost commented Jun 16, 2020

I am not colorblind; I am having trouble reading text on .footer and .page-nav. When using WebAIM Contrast Checker, the color combination for text and background fails tests for WCAG AAA and WCAG AA. The contrast should at least pass WCAG AA for better readability.

@nknapp
Copy link
Contributor

nknapp commented Jun 18, 2020

Hi and thanks for pointing this out. I hadn't known this tool, but I shall give it a try in the future.
In this case, I have to admit, I just copied the colors from the original Handlebars site and tried my best to make it look alike.

At the moment, I don't have much time to take care of this, but if you like to play around with different colors, please don't hesitate to submit a PR: The changes need to be made in this directory.

@nknapp
Copy link
Contributor

nknapp commented Jun 18, 2020

Is there any tool that can be included into the CI/CD-build to check such problems automatically?

@ilharp
Copy link
Contributor

ilharp commented Jun 19, 2020

There are several tools that can help check the website's "Accessibility" (a11y) such as stylelint-a11y, a plugin of StyleLint. But I think this does not meet the actual needs.

At present, the tool I found to meet the needs is Web Accessibility Evaluation Tool (WAVE), which provides an online inspection page (here is an example for Handlebars Docs) and browser plugins, but it does not provide a free API.

There may be other free tools to solve this problem... but I haven't found one yet.

@papasmile
Copy link
Contributor

There are handy tools like https://github.com/nickcolley/jest-axe when we have fully rendered components; but since we are using a site generator I think we'd have to run a full browser-test suite (eg Selenium) to get decent tooling. That's a significant undertaking even for a small-ish site... perhaps just fix offensive CSS manually for now?

@nknapp
Copy link
Contributor

nknapp commented Jul 9, 2020

would be cool though to have such a tool for vuepress. It could also be used by other sites...

@nknapp
Copy link
Contributor

nknapp commented Jul 9, 2020

but I agree, at the moment, it should just be fixed in the CSS. I just always ask myself this question: Could we use tools to prevent this in the future.

@jaylinski
Copy link
Member

I'd use https://github.com/GoogleChrome/lighthouse-ci for this. It has accessibility checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants