Remove the need for AllowDynamicProperties in CurlMultiHandler
#3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh. Can you re-gen the psalm baseline plz - I'm happy that we just make it stfu for these changes for now. ;) |
|
Okay, I have no idea what I did wrong, but CI still is red. It was not easy to get PHPStan and Psalm working in the first place, because apparently they are broken on PHP 8.2 (and also complain when executed with PHP 7.4 like in CI). |
|
@GrahamCampbell Got it to work, CI is green now. |
TimWolla
force-pushed
the
less-allowed-dynamic-properties
branch
from
b384fbc
to
c02be01
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see guzzle/psr7#547