Corrected docs and default connect timeout value to 300 seconds #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Do you know when this changed. I don't think this was always the case? |
|
@GrahamCampbell unfortunately I don't know if it has ever been changed. |
|
Hahahaha. I'd totally forgotten I PRed something similar. 😆 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions. |
GrahamCampbell
changed the title
connect_timeout values around the code and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per cURL documentation if
CURLOPT_CONNECTTIMEOUTset to0it means 300 seconds timeout:Additionally, curl provides 2 options to set connect timeout:
CURLOPT_CONNECTTIMEOUT
CURLOPT_CONNECTTIMEOUT_MS
As mentioned,
If both CURLOPT_CONNECTTIMEOUT and CURLOPT_CONNECTTIMEOUT_MS are set, the value set last will be used.Guzzle code sets
CURLOPT_CONNECTTIMEOUTto default 150, but then usesCURLOPT_CONNECTTIMEOUT_MSto overwrite this value.This PR replaces
CURLOPT_CONNECTTIMEOUTonCURLOPT_CONNECTTIMEOUT_MSand changes the default value for connect timeout from 150 to 300 to get rid of the wrong behaviour.