Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review naming of relative option in symlink and dest #251

Closed
phated opened this issue Jun 23, 2017 · 3 comments
Closed

Review naming of relative option in symlink and dest #251

phated opened this issue Jun 23, 2017 · 3 comments

Comments

@phated
Copy link
Member

phated commented Jun 23, 2017

The name of this option is really confusing. I think it should be renamed so it makes more sense across methods.

Maybe something like relativeLinks

@erikkemperman
Copy link
Member

To keep things consistent with resolveSymlinks maybe it should be relativeSymlinks? That would get a bit verbose though so alternatively all of them could just end with ..Links?

@phated
Copy link
Member Author

phated commented Jun 26, 2017

I like relativeSymlinks

@erikkemperman
Copy link
Member

👍🏻

@phated phated closed this as completed in d9aab22 Jun 29, 2017
erikkemperman pushed a commit to erikkemperman/vinyl-fs that referenced this issue Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants