Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests shouldn't need isDarwin check with custom mkdirp #183

Closed
phated opened this issue Jun 29, 2016 · 2 comments
Closed

Tests shouldn't need isDarwin check with custom mkdirp #183

phated opened this issue Jun 29, 2016 · 2 comments

Comments

@phated
Copy link
Member

phated commented Jun 29, 2016

It seems that the tests are currently passing with the check still implemented. Need to look into this.

@erikkemperman
Copy link
Member

erikkemperman commented Jun 29, 2016

For what it's worth -- I thought it was quirky before the mkdirp merge...

On my mac, the isDarwin distinction was indeed necessary, or the "different modes for files and directories" test would fail. But on my mint linux box I also had to force isDarwin to be true, even though on travis (which I think is a kind of debian?) it works as intended!

I guess we may need to test the mkdirp logic with masks including the sticky/setuid/setgid bits to see what sticks (ha) on which platforms?

@phated
Copy link
Member Author

phated commented Jun 29, 2016

I've got this mostly figured out. Just need some feedback on #185 before I commit all the changes.

@phated phated closed this as completed in a6c1f05 Jun 30, 2016
phated added a commit that referenced this issue Jun 30, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Jun 30, 2016
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 27, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 28, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 30, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 30, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 30, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 30, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Nov 30, 2017
…unt for umask with default mode (closes #183, closes #185)
phated added a commit that referenced this issue Dec 5, 2017
…unt for umask with default mode (closes #183, closes #185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants