-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests shouldn't need isDarwin check with custom mkdirp #183
Comments
For what it's worth -- I thought it was quirky before the mkdirp merge... On my mac, the isDarwin distinction was indeed necessary, or the "different modes for files and directories" test would fail. But on my mint linux box I also had to force isDarwin to be true, even though on travis (which I think is a kind of debian?) it works as intended! I guess we may need to test the mkdirp logic with masks including the sticky/setuid/setgid bits to see what sticks (ha) on which platforms? |
I've got this mostly figured out. Just need some feedback on #185 before I commit all the changes. |
It seems that the tests are currently passing with the check still implemented. Need to look into this.
The text was updated successfully, but these errors were encountered: