Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Design Tokens package to export multiple objects #1380

Merged
merged 17 commits into from
Apr 26, 2024
Merged

Update Design Tokens package to export multiple objects #1380

merged 17 commits into from
Apr 26, 2024

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Apr 25, 2024 •
edited by jamesmockett

What are you changing?

  • Updates Design Tokens package to export separate objects for the different types of token. e.g. palette, typography, spacing etc.

Why?

  • Currently all tokens are exported as a single object which can't be tree shaken, leading to some bloat in Source Foundations where it's having to import more JS than required.

@oliverabrahams oliverabrahams requested review from a team as code owners April 25, 2024 15:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited

🦋 Changeset detected

Latest commit: 59fe57a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/source-foundations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Apr 25, 2024
@oliverabrahams oliverabrahams marked this pull request as draft April 25, 2024 15:39
@oliverabrahams oliverabrahams added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@oliverabrahams oliverabrahams removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Apr 25, 2024
@oliverabrahams oliverabrahams added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@oliverabrahams oliverabrahams removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Apr 26, 2024
@oliverabrahams oliverabrahams marked this pull request as ready for review April 26, 2024 10:36
@oliverabrahams oliverabrahams requested review from a team as code owners April 26, 2024 10:36
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Apr 26, 2024
@jamesmockett jamesmockett changed the title Design tokens to export multiple objects Update Design Tokens package to export multiple objects Apr 26, 2024
@oliverabrahams oliverabrahams merged commit a8195c6 into main Apr 26, 2024
20 checks passed
@oliverabrahams oliverabrahams deleted the jm/token-multiple-exports branch April 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmockett jamesmockett jamesmockett approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliverabrahams @jamesmockett