Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ab-core for clearer intent #1377

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Refactor ab-core for clearer intent #1377

merged 2 commits into from
Apr 24, 2024

Conversation

mxdvl
Copy link
Member

@mxdvl mxdvl commented Apr 24, 2024

What are you changing?

  • use nullish coalescing to convert a boolean | undefined into a boolean

Why?

nullish coalescing is shorter and more
expressive about the intent
@mxdvl mxdvl requested a review from a team as a code owner April 24, 2024 14:05
Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 038f201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/ab-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@sndrs sndrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one - can you add a changeset?

@mxdvl mxdvl requested review from a team as code owners April 24, 2024 14:11
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Apr 24, 2024
@mxdvl mxdvl enabled auto-merge (squash) April 24, 2024 14:19
@mxdvl mxdvl merged commit a247de9 into main Apr 24, 2024
22 checks passed
@mxdvl mxdvl deleted the mxdvl/ab-core-refactor branch April 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/ab-core 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants