Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat timeAgo code for consistency #1376

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Reformat timeAgo code for consistency #1376

merged 2 commits into from
Apr 25, 2024

Conversation

mxdvl
Copy link
Member

@mxdvl mxdvl commented Apr 24, 2024

What are you changing?

  • wrap all exhaustive conditionals in the if/else if/else pattern

Why?

a follow-up on recent linting rules change meant
that this code did not read as clearly
@mxdvl mxdvl requested review from a team as code owners April 24, 2024 13:58
Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: b2bb23f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/libs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@mxdvl mxdvl requested review from a team as code owners April 24, 2024 14:16
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Apr 24, 2024
@mxdvl mxdvl merged commit becac1a into main Apr 25, 2024
22 checks passed
@mxdvl mxdvl deleted the mxdvl/timeAgo-refactor branch April 25, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants