Add object literal representation of typography presets #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
jamesmockett
force-pushed
the
jm/preset-objects
branch
from
2d26efc
to
97dae1f
Compare
oliverabrahams
merged commit d28774a
into
jm/type-preset-release-branch
10 checks passed
|
Would we want these objects to be marked |
I hadn't thought of that, but yes, I think that's a good idea 👍 |
jamesmockett
added a commit
that referenced
this pull request
Apr 16, 2024
* Basic build script to generate presets vars * Format build output with Prettier * Move build script to nx target * Add presets to exports and export tests * Strip additional whitespace and tabs from output * Add building presets as dependency to build task * Update incorrect font sizes in Text Sans presets * Add preset examples to tests * Convert px font sizes to rems * Update build script messaging * Add complete set of tests for all presets * Add typography presets and examples to Storybook * Show type properties alongside examples * Add Story block so presets are available as separate story * Fix invalid markup * Reinstate typography API docs and mark as deprecated * Rename preset specimen renderer * Basic build script to generate presets vars * Format build output with Prettier * Move build script to nx target * Add presets to exports and export tests * Strip additional whitespace and tabs from output * Add building presets as dependency to build task * Update incorrect font sizes in Text Sans presets * Add preset examples to tests * Convert px font sizes to rems * Update build script messaging * Add complete set of tests for all presets * Move deprecated typography API docs to separate story * Add text decoration style to preset CSS * Add object literal representation of typography presets (#1283) Add object literal representation of type presets * Type preset objects `as const` (#1306) * Relocate deprecated typography API code * Mark typography API exports as deprecated * Fix casing of 'italic' in tokens * Pin tsx version * move typography docs into `stories` * auto-generated files are built to `vendor` * add changeset * format changeset * Update references to generated code * Make conversion function types more specific * Update deprecation messages and add link to docs * Add object style example * Remove article and kicker presets * Update docs to remove article and kicker * Update link to mapping example in changelog * Mark object style exports as deprecated * Update story types and imports * Rename object style exports so names are unique * Fix linting errors * Add note about getting assistance to changelog * Update wording in changelog Co-authored-by: Alex Sanders <alex@sndrs.dev> --------- Co-authored-by: Max Duval <max.duval@theguardian.com> Co-authored-by: Alex Sanders <alex@sndrs.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Adds object literal representation of the web typography presets.