Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include --source-text-decoration-thickness in preset CSS #1281

Merged
merged 1 commit into from Mar 14, 2024
Merged

Include --source-text-decoration-thickness in preset CSS #1281

merged 1 commit into from Mar 14, 2024

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

Outputs --source-text-decoration-thickness custom property for each preset based on the font size.

Why?

--source-text-decoration-thickness is used by the <Link> component to apply an appropriate text decoration style for links in the hover state.

@jamesmockett jamesmockett requested review from a team as code owners March 12, 2024 17:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024 •
edited

⚠️ No Changeset found

Latest commit: a1443ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Mar 12, 2024
@jamesmockett jamesmockett linked an issue Mar 12, 2024 that may be closed by this pull request
Add text-decoration-thickness values to presets #1280
Open
oliverabrahams
oliverabrahams approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jamesmockett jamesmockett merged commit 63ed40d into jm/type-preset-release-branch Mar 14, 2024
10 checks passed
@jamesmockett jamesmockett deleted the jm/preset-text-decoration branch March 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add text-decoration-thickness values to presets
2 participants
@jamesmockett @oliverabrahams