Skip to content

Update $gtm global property augmentation #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romansp
Copy link
Contributor

@romansp romansp commented Aug 13, 2024

Fixes #464.

@ts-expect-error no longer needed 🎉 .

I updated vue peer dependency to 3.2.26 as discussed but not sure from where this exact version number is coming from to be honest. Should we just leave it at 3.2.0?

…nting 'vue' module, fixes gtm-support#464
@romansp romansp requested a review from Shinigami92 as a code owner August 13, 2024 20:51
@Shinigami92 Shinigami92 changed the title Update $gtm global property augmentation fix: update $gtm global property augmentation Aug 14, 2024
@Shinigami92 Shinigami92 changed the title fix: update $gtm global property augmentation Update $gtm global property augmentation Aug 14, 2024
@Shinigami92 Shinigami92 merged commit 7dbf04f into gtm-support:main Aug 14, 2024
4 checks passed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@romansp romansp deleted the fix-464-global-property-augmentation branch August 14, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: global property augmentation of $gtm breaks type checks
2 participants