Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Linux AMIs search fixes #1387

Merged
merged 1 commit into from Jan 16, 2024
Merged

Amazon Linux AMIs search fixes #1387

merged 1 commit into from Jan 16, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jan 16, 2024

Description

Fixed searching for Amazon Linux AMIs:

  • removed deprecated Amazon Linux 1 reference
  • added usage of Amazon Linux 2

Fixes #1386.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Updated GetAmazonLinuxAmiE to search for Amazon Linux 2 AMIs

Migration Guide

@denis256 denis256 self-assigned this Jan 16, 2024
@denis256 denis256 changed the title [WIP] CICD tests fixes Amazon Linux AMIs search fixes Jan 16, 2024
@denis256 denis256 marked this pull request as ready for review January 16, 2024 19:55
Copy link
Contributor

@gcagle3 gcagle3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit 7556978 into master Jan 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws][ami]Amazon Linux 1 AMI No Longer Available
2 participants