Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds custom logger to kubectl options #1325

Merged
merged 1 commit into from Jul 25, 2023

Conversation

retpolanne
Copy link
Contributor

This commit adds the custom logging facility to kubectl options and to the Kubectl Run with output that can be used to suppress stdout from Kubectl run if needed.

The logging facility was introduced on #510 but it missed kubectl options.

Fixes #358 since @blame19 recalled that the behavior was missing on the k8s module.

TODOs

Read the Gruntwork contribution guidelines.

  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated k8s module to add custom logging facility

This commit adds the custom logging facility to kubectl options and to
the Kubectl Run with output that can be used to suppress stdout from
Kubectl run if needed.

The logging facility was introduced on gruntwork-io#510 but it missed kubectl
options.

Fixes gruntwork-io#358 since @blame19 recalled that the behavior was missing on the
k8s module.

Signed-off-by: Anne Macedo <retpolanne@posteo.net>
@denis256 denis256 merged commit 7f3b965 into gruntwork-io:master Jul 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to disable terraform's output when running test
2 participants