Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Kubernetes dependencies #1298

Merged
merged 7 commits into from May 30, 2023
Merged

Updated Kubernetes dependencies #1298

merged 7 commits into from May 30, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented May 26, 2023 •
edited

Description

Included changes:

  • Updated Kubernetes dependencies:
	k8s.io/api v0.27.2
	k8s.io/apimachinery v0.27.2
	k8s.io/client-go v0.27.2
  • Updated go version to 1.19 to build new dependencies
# k8s.io/kube-openapi/pkg/cached
../.go_workspace/pkg/mod/k8s.io/kube-openapi@v0.0.0-20230501164219-8b0f38b5fd1f/pkg/cached/cache.go:242:16: undefined: atomic.Pointer
note: module requires Go 1.19
FAIL	github.com/gruntwork-io/terratest/modules/k8s [build failed]

Fixes #1290.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated Go version to 1.19.
Updated Kubernetes client dependencies.

Migration Guide

@denis256 denis256 changed the title [WIP] Updated terratest dependencies to latest versions [WIP] Updated Kubernetes dependencies May 26, 2023
@denis256 denis256 changed the title [WIP] Updated Kubernetes dependencies Updated Kubernetes dependencies May 29, 2023
@denis256 denis256 marked this pull request as ready for review May 29, 2023 20:34
@denis256 denis256 requested a review from zackproser as a code owner May 29, 2023 20:34
zackproser
zackproser approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed tests are known flaky, so LGTM

@denis256 denis256 merged commit 5db8597 into master May 30, 2023
2 of 3 checks passed
@denis256 denis256 deleted the terratest-deps-upgrade branch May 30, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with k8s/apimachinery v1.25 or later
2 participants
@denis256 @zackproser